This repository was archived by the owner on Nov 7, 2020. It is now read-only.
Clear (blank) the layer before updating#1
Open
feri wants to merge 1 commit intosmallstoneapps:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a project of mine I have a window containing 2 text layers (like header and footer), and in between I have the QR layer. I always had a valid QR displayed upon creation, but it always became invalid (ie. no reader could read it) when I tried to update it (using qr_layer_set_data).
After a bit of playing I realized that "clearing" the GRect first helps. My patch basically fills the GRect with a pre-defined BG color, and then sets the fill color back to "black". Unfortunately I could not find a call to read the fill colors, so therefore I defined them in the header. I don't like this part, but well, works for me..
I really like the idea of using a new layer for this purpose. Thank you for this great lib!!